[DependencyInjection] Optimize circular collection by removing flattening #39021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9327084 to
d077e62
Compare
| return $this->services['manager3'] = new \stdClass($b); | ||
| $a->listener = [0 => ($this->services['listener3'] ?? $this->getListener3Service())]; | ||
|
|
||
| return $instance; |
There was a problem hiding this comment.
The order of injection in this test case has changed:
manager3 is given a dependency that is missing its listener3 dep.
This is an issue to me, since these test cases are precisely about the order of the steps.
There was a problem hiding this comment.
I'm not sure to get the issue. Here are the 2 methods.
protected function getManager3Service($lazyLoad = true)
{
$a = new \stdClass();
$this->services['manager3'] = $instance = new \stdClass($a);
$a->listener = [0 => ($this->services['listener3'] ?? $this->getListener3Service())];
return $instance;
}
protected function getListener3Service()
{
$this->services['listener3'] = $instance = new \stdClass();
$instance->manager = ($this->services['manager3'] ?? $this->getManager3Service());
return $instance;
}There was a problem hiding this comment.
Before the change, getManager3 returned $this->services['manager3'] = new \stdClass($b);, with $b being already configured (aka $b->listener set)
In the new method, the listener propery is set after manager3 got its dep.
There was a problem hiding this comment.
hmmm ok, I get the issue: The object ($a) were not fully built at the time it were injected in Manager's constructor.
There was a problem hiding this comment.
And also fix the second change (because I didn't collect ALL circular references for the same node).
Fixtures are identical to previous version. I tested with the projects I used for the 2 previous issues on this.
de7ff0f to
85d8004
Compare
d3b951b to
136908f
Compare
136908f to
e649f47
Compare
nicolas-grekas
approved these changes
Nov 9, 2020
|
Thank you @jderusse. |
Merged
derrabus
added a commit
that referenced
this pull request
Nov 12, 2020
… paths (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix circular detection with multiple paths | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39056 | License | MIT | Doc PR | - There are currently 2 kind of issues related to the Dependency Injection: 1. performance issue when project contains many loops (#37850) Which has been fixed by #38882 2. Infinity loop in some case (#38970) Which has been fixed by #38980 and #39021 The new issue #39056 has been introduced by #38882 (The performance issue refactor) because in order to optimize loop detection, I take a short cut and choose to not collect ALL the circular loop but only the one that matters I was wrong. All loops matters. This PR fix my previous refacto to collect ALL the paths, with a low CPU footprint Commits ------- 1c3721e Fix circular detection with multiple paths
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2020
…truct loop (jderusse) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix circular in DI with lazy + byContruct loop | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39120 | License | MIT | Doc PR | - This fix another issue lazy service. It partially revert #38980 and #39021 Initially, we trusted lazy services to be lazy and not beeing called while building the services graph => bug #38970 when lazy deps is injected in a factory, it may be consumed directly to build the object before the graph is fully built Fixed by #38980 => lazy service are considered as "normal service" => bug #39015 some loop are not resolvable with "normal service", but it shouldn't be an issue when servie proxifyied Fixed by #39021 => lazy service are considered as "normal service" except when proxyfied => bug #39120 some loop are not resolvable with "normal service", but it shouldn't be an issue because the lazy service is injected in the constructor and user Fixed by this PR => that revert to the initial state. lazy service are trusted. But now, The IterratorArgument injected in a factory (single exception) is not more considered as lazy Commits ------- 54af139 [DependencyInjection] Fix circular in DI with lazy + byContruct loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #39019