[Ldap] Fix pagination #39031
Merged
[Ldap] Fix pagination #39031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Nov 7, 2020
|
would be great to have tests covering that |
This is already covered by symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php Lines 132 to 135 in 7b4d22f note: Tests are not executed in our CI=> This should be solved by #39030 This PR is about fixing the issue in case neither #38875 is updated with the correct fix, nor #39030 is accepted/ready to merge. |
fabpot
approved these changes
Nov 9, 2020
|
Thank you @jderusse. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #38875 to fix a bug introduced by #38392