Skip to content

[WebProfilerBundle] Possibility to dynamically set mode #39051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

brusch
Copy link
Contributor

@brusch brusch commented Nov 11, 2020

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
License MIT

Sometimes it is necessary to dynamically decide whether the debug toolbar should be injected or not.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Nov 11, 2020
@fabpot
Copy link
Member

fabpot commented Dec 28, 2020

Can you share the use cases you have in mind?

@brusch
Copy link
Contributor Author

brusch commented Dec 28, 2020

Yep, of course 😊
One use case for us is, that we want to disable the debug toolbar for certain admin functionalities which are embedded by an <iframe>, because it's just not necessary and (sometimes) breaks the layout of the embedded contents:
image

We're currently doing this by removing the subscriber, which is also working fine. But as the functionality is already there, I thought it would make sense to also let it change dynamically 😉
https://github.com/pimcore/pimcore/blob/master/bundles/CoreBundle/EventListener/WebDebugToolbarListener.php#L97

@fabpot
Copy link
Member

fabpot commented Jan 5, 2021

Thank you @brusch.

@fabpot fabpot merged commit 47e4b8e into symfony:5.x Jan 5, 2021
@brusch brusch deleted the patch-1 branch January 5, 2021 07:20
@fabpot fabpot mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants