[FrameworkBundle] [Notifier] fix firebase transport factory DI tag type #39072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 13, 2020
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #39062 |
| License | MIT |
| Doc PR |
weaverryan
added a commit
to symfony-tools/carsonbot
that referenced
this pull request
Nov 13, 2020
This PR was merged into the master branch. Discussion ---------- Added more logs There are some issues when adding labels to the PRs. I need even more logs to figure out what is wrong. See symfony/symfony#39072 Commits ------- 7f9bd97 Added more logs
jschaedl
approved these changes
Nov 13, 2020
fabpot
approved these changes
Nov 14, 2020
|
Thank you @xabbuh. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.