Skip to content

[Messenger]  Allow InMemoryTransport to serialize message #39075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

[Messenger]  Allow InMemoryTransport to serialize message #39075

merged 1 commit into from
Nov 20, 2020

Conversation

tyx
Copy link
Contributor

@tyx tyx commented Nov 13, 2020

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #38893
License MIT
Doc PR wip

This introduce a query parameter in dsn to enable serialization as @Nyholm has suggested in #38893

in-memory://?serialize=true

@tyx tyx requested a review from sroze as a code owner November 13, 2020 14:16
@tyx tyx force-pushed the feature/in-memory-serializable-transport branch 2 times, most recently from 8c31932 to 916d87b Compare November 13, 2020 14:31
@carsonbot carsonbot changed the title [Messenger] Allow InMemoryTransport to serialize message [Messenger]  Allow InMemoryTransport to serialize message Nov 13, 2020
@jderusse jderusse added this to the 5.x milestone Nov 13, 2020
@chalasr
Copy link
Member

chalasr commented Nov 14, 2020

Can you please update the component's CHANGELOG? This is for 5.3.

@tyx
Copy link
Contributor Author

tyx commented Nov 16, 2020

Can you please update the component's CHANGELOG? This is for 5.3.

So I need to create CHANGELOG-5.3.md ?

@tyx tyx force-pushed the feature/in-memory-serializable-transport branch from 916d87b to e85f039 Compare November 16, 2020 09:00
@chalasr
Copy link
Member

chalasr commented Nov 16, 2020

@tyx Nope, you need to add a new 5.3.0 section at the top of the https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/Messenger/CHANGELOG.md

@tyx tyx force-pushed the feature/in-memory-serializable-transport branch from e85f039 to 46a8007 Compare November 16, 2020 13:28
@tyx
Copy link
Contributor Author

tyx commented Nov 16, 2020

Ok done !

@chalasr
Copy link
Member

chalasr commented Nov 20, 2020

Thank you @tyx.

@chalasr chalasr mentioned this pull request Nov 20, 2020
Closed
@chalasr chalasr merged commit a273b71 into symfony:5.x Nov 20, 2020
@tyx tyx deleted the feature/in-memory-serializable-transport branch November 20, 2020 11:44
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@jderusse jderusse jderusse approved these changes

@chalasr chalasr chalasr approved these changes

@maxhelias maxhelias maxhelias approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] Add serializer usage to InMemoryTransport
7 participants
@tyx @chalasr @jderusse @derrabus @maxhelias @Nyholm @carsonbot