Skip to content

[Notifier] add iqsms bridge #39096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

[Notifier] add iqsms bridge #39096

merged 1 commit into from
Dec 17, 2020

Conversation

alexandrbarabolia
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#14555
Hi,

I've created integration to notifier to support russian sms operator - iqsms

Can you grab this code and make as symfony/iqsms-notifier?

This PR includes changes in notifier and framework-bundle to support smsapi transport as well as other included in notifier component.

Could someone integrate this into notifier component?

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark mentioned this pull request Nov 16, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Nov 17, 2020
@OskarStark
Copy link
Contributor

Please add some tests, thank you

@alexandrbarabolia
Copy link
Contributor Author

Please add some tests, thank you

already added, thank for review

@wouterj wouterj removed their request for review December 16, 2020 22:11
OskarStark
OskarStark requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last changes, afterwards good to go 👍

Thank you for your patience ❤️

OskarStark added a commit to OskarStark/recipes that referenced this pull request Dec 17, 2020
@OskarStark
Add recipe for symfony/iqsms-notifier
29f4473 
cc @alexandrbarabolia

refs symfony/symfony#39096
@OskarStark OskarStark mentioned this pull request Dec 17, 2020
Merged
@OskarStark
Copy link
Contributor

I added a recipe for the new bridge: symfony/recipes#860

@fabpot fabpot force-pushed the feature/add_iqsms_bridge branch from d19c957 to bf94bcb Compare December 17, 2020 16:52
@fabpot
Copy link
Member

fabpot commented Dec 17, 2020

Thank you @alexandrbarabolia.

@fabpot fabpot merged commit e533bd3 into symfony:5.x Dec 17, 2020
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 17, 2020
@OskarStark
feature #14555 [Notifier] add iqsms bridge support in doc (alexandrba…
e0919bf 
…rabolia)

This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] add iqsms bridge support in doc

add iqsms-notifier documentation

symfony/symfony#39096

Commits
-------

41285f0 [Notifier] add iqsms bridge support in doc
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaedl jschaedl jschaedl left review comments

@OskarStark OskarStark OskarStark requested changes

@fabpot fabpot fabpot approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@alexandrbarabolia @carsonbot @OskarStark @fabpot @derrabus @jschaedl @nicolas-grekas