[PhpUnitBridge] Add log file option for deprecations #39098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelKaefer
commented
Nov 16, 2020
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #37679 |
| License | MIT |
| Doc PR | symfony/symfony-docs#14558 |
bf698e0 to
c82c997
Compare
|
@noniagriconomie Thank you for the review! I have a question concerning the scalar type hints and the return types: are you sure I should add them? The reason why I didn't:
More reasons (maybe not valid reasons):
|
|
@michaelKaefer you are right yep I was thinking v5 was 7+ and I checked the main repo composer.json, not the one of the bridge, sorry for this wrong hint :/ |
The PHPUnit bridge is special in its PHP support. To make our maintenance easier, the latest version of the phpunit bridge is kept compatible with PHP versions supported by all maintained branches (and so the min version corresponds to the one of the LTS) |
|
@stof very clear :) thx for this explanation |
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
Outdated
Show resolved
Hide resolved
3b50ce3 to
74dfbb6
Compare
cb6537f to
ad78189
Compare
ad78189 to
3ed22be
Compare
nicolas-grekas
approved these changes
Jan 5, 2021
|
Thank you @michaelKaefer. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 7, 2021
…elKaefer) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [PHPUnitBridge] Add deprecation log file option For PR symfony/symfony#39098 Commits ------- 66d5f49 [PHPUnitBridge] Add deprecation log file option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.