Skip to content

[DoctrineBridge] drop binary variants of UID types #39113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020
Merged

[DoctrineBridge] drop binary variants of UID types #39113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Doctrine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CHANGELOG
5.2.0
-----

* added support for symfony/uid as `UlidType`, `UuidType`, `UlidBinaryType` and `UuidBinaryType` as Doctrine types
* added support for symfony/uid as `UlidType` and `UuidType` as Doctrine types
* added `UlidGenerator`, `UUidV1Generator`, `UuidV4Generator` and `UuidV6Generator`

5.0.0
Expand Down
10 changes: 0 additions & 10 deletions src/Symfony/Bridge/Doctrine/DependencyInjection/CompilerPass/RegisterUidTypePass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@

namespace Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass;

use Symfony\Bridge\Doctrine\Types\UlidBinaryType;
use Symfony\Bridge\Doctrine\Types\UlidType;
use Symfony\Bridge\Doctrine\Types\UuidBinaryType;
use Symfony\Bridge\Doctrine\Types\UuidType;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
Expand All @@ -40,14 +38,6 @@ public function process(ContainerBuilder $container)
$typeDefinition['ulid'] = ['class' => UlidType::class];
}

if (!isset($typeDefinition['uuid_binary'])) {
$typeDefinition['uuid_binary'] = ['class' => UuidBinaryType::class];
}

if (!isset($typeDefinition['ulid_binary'])) {
$typeDefinition['ulid_binary'] = ['class' => UlidBinaryType::class];
}

$container->setParameter('doctrine.dbal.connection_factory.types', $typeDefinition);
}
}
114 changes: 0 additions & 114 deletions src/Symfony/Bridge/Doctrine/Tests/Types/UlidBinaryTypeTest.php
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/Symfony/Bridge/Doctrine/Tests/Types/UlidTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ public static function setUpBeforeClass(): void
protected function setUp(): void
{
$this->platform = $this->createMock(AbstractPlatform::class);
$this->platform
->method('hasNativeGuidType')
->willReturn(true);
$this->platform
->method('getGuidTypeDeclarationSQL')
->willReturn('DUMMYVARCHAR()');
Expand Down
123 changes: 0 additions & 123 deletions src/Symfony/Bridge/Doctrine/Tests/Types/UuidBinaryTypeTest.php
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/Symfony/Bridge/Doctrine/Tests/Types/UuidTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ public static function setUpBeforeClass(): void
protected function setUp(): void
{
$this->platform = $this->createMock(AbstractPlatform::class);
$this->platform
->method('hasNativeGuidType')
->willReturn(true);
$this->platform
->method('getGuidTypeDeclarationSQL')
->willReturn('DUMMYVARCHAR()');
Expand Down
86 changes: 0 additions & 86 deletions src/Symfony/Bridge/Doctrine/Types/AbstractBinaryUidType.php
View file
Open in desktop

This file was deleted.

Loading