[Cache] Fix CI because of Couchbase version #39131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Nov 20, 2020
| @@ -16,7 +16,8 @@ | |||
| use Symfony\Component\Cache\Adapter\CouchbaseBucketAdapter; | |||
|
|
|||
| /** | |||
| * @requires extension couchbase 2.6.0 | |||
| * @requires extension couchbase <3.0.0 | |||
There was a problem hiding this comment.
duplicate with check in setupBeforeClass because not all version of phpunit supports multiple requires on the same extension
derrabus
approved these changes
Nov 20, 2020
fabpot
approved these changes
Nov 21, 2020
|
Thank you @jderusse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks likes the version 3.0 of the couchbase extension does not exposes the
\CouchbaseClusterclass anymore.I didn't find documentaiton about the BC break, but their documentation changes
version 2.6 => https://docs.couchbase.com/php-sdk/2.6/managing-connections.html
version 3.0 => https://docs.couchbase.com/php-sdk/current/howtos/managing-connections.html
It wasn't reported before, because
shivammathur/setup-phpadded the extension 3days ago shivammathur/setup-php#337Sounds like the adapter were never tested, because the extension where missing and phpunit skipped the tests.