Skip to content

[Console] Added Invalid constant into Command Class #39146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2020
Merged

[Console] Added Invalid constant into Command Class #39146

merged 1 commit into from
Nov 27, 2020

Conversation

TheGarious
Copy link
Contributor

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
License MIT

Regarding into this link, we have 3 exits status standard :

  • 0 is for success
  • 1 is for error
  • 2 is for indicate incorrect usage, generally invalid options or missing arguments

I think if we use a constant into Command class, we need to implement invalid exit status too.

@TheGarious TheGarious requested a review from chalasr as a code owner November 23, 2020 16:02
@carsonbot carsonbot changed the title Added Invalid constant into Command Class [Console] Added Invalid constant into Command Class Nov 23, 2020
@derrabus derrabus added this to the 5.x milestone Nov 26, 2020
@fabpot
Copy link
Member

fabpot commented Nov 27, 2020

Thank you @TheGarious.

@fabpot fabpot mentioned this pull request Nov 27, 2020
Closed
@fabpot fabpot merged commit 4346ef4 into symfony:5.x Nov 27, 2020
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@TheGarious @fabpot @derrabus @carsonbot