[DI] Fix Xdebug 3.0 detection #39196
Conversation
| if ( | ||
| $message instanceof \Closure | ||
| && (\function_exists('xdebug_is_enabled') && xdebug_is_enabled() || \function_exists('xdebug_info')) | ||
| ) { | ||
| $message = $message(); |
There was a problem hiding this comment.
@derickr FYI we have this check here because xdebug changes the behavior of PHP in a way that prevents us from doing a lazy evaluation here: native PHP allows one to set the $message property of throwables to a stringable. We use this below.
It would be great if xdebug could preserve this behavior, if possible.
There was a problem hiding this comment.
I think i came up with a better solution. Please check the second commit, which replaces all xdebug-related stuff with resolving the messageCallback when the __toString method is called.
This will also eliminate performance drawbacks when xdebug is installed.
There was a problem hiding this comment.
I think i came up with a better solution. Please check the second commit, which replaces all xdebug-related stuff with resolving the messageCallback when the __toString method is called.
This will also eliminate performance drawbacks when xdebug is installed.
I take this back. getMessage() does not return the actual message.
|
On Fri, 27 Nov 2020, Nicolas Grekas wrote:
@derickr FYI we have this check here because xdebug changes the
behavior of PHP in a way that prevents us from doing a lazy evaluation
here: native PHP allows one to set the $message property of throwables
to a stringable. We use this below. It would be great if debug could
preserve this behavior, if possible.
Xdebug shouldn't be changing behaviour, can you file a bug report at
https://bugs.xdebug.org ?
cheers,
Derick
…--
PHP 7.4 Release Manager
Host of PHP Internals News: https://phpinternals.news
Like Xdebug? Consider supporting me: https://xdebug.org/support
https://derickrethans.nl | https://xdebug.org | https://dram.io
twitter: @derickr and @xdebug
|
|
I submitted an issue at https://bugs.xdebug.org/view.php?id=1907 |
|
Thank you @vertexvaar. |
Xdebug 3.0 removed the function
xdebug_is_enabled(). To detect if Xdebug 3.0 is installed (it doesn't even need to be enabled to reproduce the bug) i addedfunction_exists('xdebug_info'). AFAISxdebug_info()is available in Xdebug >= 3.0 only.