Skip to content

[Yaml] Unexpected character when whitespace ends the line #39234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 30, 2020

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39229
License MIT
Doc PR

Adding test for issue #39229. These will only fail on windows.. or at least that is the rumour.

@Nyholm Nyholm requested a review from xabbuh as a code owner November 30, 2020 11:00
@carsonbot carsonbot added this to the 5.2 milestone Nov 30, 2020
@Nyholm Nyholm changed the title [Yaml] Unexpected file endings on Windows [Yaml] Unexpected character when whitespace ends the line Nov 30, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Nov 30, 2020

@xabbuh Is this something that should be fixed?

The issue was not introduced in 5.2

@Nyholm
Copy link
Member Author

Nyholm commented Nov 30, 2020

Yes, it should be fixed. The issue was caused by #33763

@Nyholm Nyholm changed the base branch from 5.2 to 4.4 November 30, 2020 12:02
@Nyholm Nyholm modified the milestones: 5.2, 4.4 Nov 30, 2020
@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2020

I am going to look into it.

@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2020

will be fixed by #39241

@xabbuh xabbuh closed this Nov 30, 2020
@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2020

Thank for spotting the root cause @Nyholm!

@Nyholm
Copy link
Member Author

Nyholm commented Nov 30, 2020

Thank you for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants