[Security] more defensive PasswordMigratingListener #39263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add this case to |
9baed0c to
0222ed3
Compare
|
Sure, I just added a test case. I struggled a bit with PHPUnit stubbing (usually I'm using anonymous classes), please tell me if that looks good to you and consistent with the rest of the codebase. |
wouterj
approved these changes
Dec 1, 2020
derrabus
approved these changes
Dec 1, 2020
|
Thank you @romaricdrigon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed fix makes
PasswordMigratingListenercode more robust. It should handle Passports which does not contain anUserBadge, as it is not enforced byUserPassportInterface. Developers should be free to implement different passports with different badges (as I did on my own project), and it shouldn't lead to a crash in frameworkland.The issue became apparent in 5.2.0 exactly, as
PasswordMigratingListeneris now called in (almost) every login, asPasswordUpgradeBadgeis automatically added.