Skip to content

[HttpClient] Use decoration instead of class replacement for mock factory #39268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

[HttpClient] Use decoration instead of class replacement for mock factory #39268

merged 1 commit into from
Dec 8, 2020

Conversation

GaryPEGEOT
Copy link
Contributor

@GaryPEGEOT GaryPEGEOT commented Dec 1, 2020 •
edited
Loading

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39266
License MIT

@carsonbot carsonbot added this to the 5.2 milestone Dec 1, 2020
@nicolas-grekas
Copy link
Member

Thank you @GaryPEGEOT.

@nicolas-grekas nicolas-grekas merged commit 4df63ab into symfony:5.2 Dec 8, 2020
@Toflar
Copy link
Contributor

Toflar commented Dec 8, 2020

Oh, I didn't even notice there was a PR for my reported issue :) Thanks @GaryPEGEOT!

@GaryPEGEOT GaryPEGEOT deleted the issues-39266 branch December 8, 2020 17:38
@fabpot fabpot mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GaryPEGEOT @nicolas-grekas @Toflar @carsonbot