[Notifier] Add exception for deprecated slack dsn #39310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Dec 4, 2020
src/Symfony/Component/Notifier/Bridge/Slack/SlackTransportFactory.php
Outdated
Show resolved
Hide resolved
|
Thank you for working on this issue! |
| } | ||
|
|
||
| if ('/' !== $dsn->getPath()) { | ||
| throw new InvalidArgumentException(sprintf('Invalid "%s" notifier DSN: Using a dsn for slack webhooks has been removed (maybe you haven\'t update the DSN when upgrading from 5.1).', $dsn->getOriginalDsn())); |
There was a problem hiding this comment.
Maybe better to use throw new IncompleteDsnException('Support for slack webhook dsn has been dropped since 5.2 (maybe you haven\'t updated the DSN when upgrading from 5.1).');?
There was a problem hiding this comment.
I agree.
Please, change "webhook dsn" to "webhook DSN".
There was a problem hiding this comment.
But Incomplete... is missleading, it's a wrong DSN... 🧐
There was a problem hiding this comment.
@OskarStark That was also my first thought but i wasn't sure if it is okay if i a add a new exception.
jderusse
reviewed
Dec 4, 2020
fabpot
requested changes
Dec 5, 2020
| } | ||
|
|
||
| if ('/' !== $dsn->getPath()) { | ||
| throw new InvalidArgumentException(sprintf('Invalid "%s" notifier DSN: Using a dsn for slack webhooks has been removed (maybe you haven\'t update the DSN when upgrading from 5.1).', $dsn->getOriginalDsn())); |
There was a problem hiding this comment.
I agree.
Please, change "webhook dsn" to "webhook DSN".
fabpot
approved these changes
Dec 8, 2020
|
Thank you @malteschlueter. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSN for the Slack integration changed again from 5.1 to 5.2. There was the idea to output an exception for that.