[FrameworkBundle] Add validator.expression_language service #39327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I like what you have done here. To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
derrabus
approved these changes
Dec 5, 2020
|
I think this could even be considered as a bugfix. |
bykclk
approved these changes
Dec 5, 2020
|
Should I rebase on 4.4? |
|
@fbourigault I don't think so, it looks like a new feature to me. We (or perhaps this is just me really) try to be much more conservative in merging non bugs in older branches. And reading the description/code, it does not looks like a bug to me. |
fabpot
approved these changes
Dec 8, 2020
|
Thank you @fbourigault. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a
validator.expression_languageservice to allow better than in-memory caching of validation expression.This also opens possibilities to extend the expression language available in validation expression through the use of
ExpressionFunctionProviderInterfaceand a compiler pass.I tried to do something close as what exists for
security.expression_languageservice but I still have some questions.ExpressionLanguageclass?#SymfonyHackday