[Config][TwigBundle] Fixed syntax error in config #39334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this one. IIUC, the change is only for YAML, but we have other formats as well where you should not add the quotes, right? |
|
Hm. Yes. I'll try to fix this problem by updating the Yaml dumper instead. |
|
I've updated the PR, it fixes the same problem but is only updating the dumper instead of the configuration. |
fabpot
approved these changes
Dec 8, 2020
|
@Nyholm Can you have a look at the tests? |
|
Sure. PR is rebased and tests are updated |
stof
approved these changes
Dec 8, 2020
yceruto
approved these changes
Dec 8, 2020
derrabus
approved these changes
Dec 8, 2020
78a5b37 to
04d369d
Compare
|
Thank you Tobias. |
|
Wohoo. Thank you. Now there is nothing that blocks us to make Carson bot a little bit smarter =) |
|
(except for a branch sync =) ) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for such small PR. I found this when I was parsing the yaml after running
bin/console config:dump-reference TwigBundle#SymfonyHackday