[Security] Add FirewallUserAuthenticator - authenticate users in any firewall
#39346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirewallUserAuthenticator - authenticate users in any firewall
OskarStark
reviewed
Aug 4, 2021
| * @author Martin Kirilov <wucdbm@gmail.com> | ||
| * | ||
| * @final | ||
| * @experimental in 5.2 |
There was a problem hiding this comment.
If this should be introduced as experimental, it needs to target 6.0 please
|
Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #37575 (comment)
I've added a
Symfony\Bundle\SecurityBundle\Security\FirewallUserAuthenticatorto allow authenticating users in another firewall, different to the one the user is currently at.For a broader reasoning, please refer to the above comment link.
TODO:
FirewallContextever return a nullFirewallConfig?I'll need to know under which section to document the new feature in CHANGELOG.md. 5.x?
And possibly some guidance for Docs, I didn't have a look there yet.
@wouterj Have a look :)