-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[TwigBridge] export concatenated translations #39352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TwigBridge] export concatenated translations #39352
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Bridge/Twig/Tests/Translation/TwigExtractorTest.php
Outdated
Show resolved
Hide resolved
I changed the milestone to 5.x, as that's not a bugfix to me. |
If I read the documentation I would expect that these translations were exported and if it doesn't it's a bug to me. 4.4 is supported for another 2 years so it would be nice (at least for me) if it could be merged in there as well. |
382065b
to
122eaba
Compare
Thank you @galatea-nl. |
This PR will fix that concatenated strings are ignored by the translation:update command. Suppose you have a twig file like this:
This is not exported when using the command. This PR will fix that.