Skip to content

[TwigBridge] export concatenated translations #39352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

galatea-nl
Copy link

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39351
License MIT
Doc PR

This PR will fix that concatenated strings are ignored by the translation:update command. Suppose you have a twig file like this:

{{ ('aa' ~ 'bb') | trans }}

This is not exported when using the command. This PR will fix that.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@galatea-nl galatea-nl changed the title export concatenated translations [TwigBridge] export concatenated translations Dec 6, 2020
@stof stof modified the milestones: 4.4, 5.x Dec 8, 2020
@stof
Copy link
Member

stof commented Dec 8, 2020

I changed the milestone to 5.x, as that's not a bugfix to me.

@galatea-nl
Copy link
Author

If I read the documentation I would expect that these translations were exported and if it doesn't it's a bug to me. 4.4 is supported for another 2 years so it would be nice (at least for me) if it could be merged in there as well.

@fabpot fabpot changed the base branch from 4.4 to 5.x December 10, 2020 07:04
@fabpot fabpot force-pushed the twig_bridge_export_concatenated_strings_39351 branch from 382065b to 122eaba Compare December 10, 2020 07:04
@fabpot
Copy link
Member

fabpot commented Dec 10, 2020

Thank you @galatea-nl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update translations with concatenated strings
6 participants