[Cache] Support Redis Sentinel mode when using phpredis/phpredis extension #39363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
The version 5.2.0 of the [Redis PHP extension](http://pecl.php.net/package/redis), released back in March 2020, added support for Redis Sentinel mode with the help of the `RedisSentinel` class. Usage of the `Symfony/Cache RedisAdapter` can continue to be the same, thus relying on the `$options['redis_persistent']` option to both enable and define the master name.
src/Symfony/Component/Cache/Tests/Adapter/PredisAdapterSentinelTest.php
Outdated
Show resolved
Hide resolved
Thank you for the feedback! Not nitpicking at all. I've resolved them and added a fixup commit. The failing Travis build is not related to my changes, perhaps you could retry it? I don't have the powerz! :P |
nicolas-grekas
approved these changes
Dec 8, 2020
|
Thank you @renan. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2020
…s/phpredis extension (renan) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Cache] Support Redis Sentinel mode when using phpredis/phpredis extension | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #39362 | License | MIT | Doc PR | symfony/symfony-docs#14668 The version 5.2.0 of the [Redis PHP extension](http://pecl.php.net/package/redis), released back in March 2020, added support for Redis Sentinel mode with the help of the `RedisSentinel` class. Usage of the `Symfony/Cache RedisAdapter` can continue to be the same, thus relying on the `$options['redis_persistent']` option to both enable and define the master name. Commits ------- 814ffab [Cache] Support Redis Sentinel mode when using phpredis/phpredis extension
renan
commented
Dec 8, 2020
|
I'm going to fix that inline, thanks for the notice. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2020
… `\Redis` (ferrastas) This PR was merged into the 5.3-dev branch. Discussion ---------- [Cache] Make use of `read_timeout` in `\RedisSentinel` and `\Redis` | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39429 | License | MIT This is a bugfix for #39363 a feature introduced in 5.x As described in issue #39429, `\RedisSentinel` accepts an optional read timeout value during construction. `read_timeout` is already part of the connection options, this PR just make use of it. Commits ------- 14e36a2 [Cache] Make use of `read_timeout` in `\RedisSentinel` and `\Redis`
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 7, 2021
… extension (renan) This PR was merged into the 5.3-dev branch. Discussion ---------- Support Redis Sentinel mode when using phpredis/phpredis extension See symfony/symfony#39363 Commits ------- 46d1f1a Support Redis Sentinel mode when using phpredis/phpredis extension
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version 5.2.0 of the Redis PHP extension, released back in March 2020, added support for Redis Sentinel mode with the help of the
RedisSentinelclass.Usage of the
Symfony/Cache RedisAdaptercan continue to be the same, thus relying on the$options['redis_persistent']option to both enable and define the master name.