[Notifier] [Twilio] Add tests #39409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Dec 9, 2020
•
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | --- |
| License | MIT |
| Doc PR | --- |
OskarStark
commented
Dec 9, 2020
Comment on lines
+36
to
+40
|
|
||
| if (!$from) { | ||
| throw new IncompleteDsnException('Missing from.', $dsn->getOriginalDsn()); | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be considered a bugfix
|
Maybe you can add .gitattributes to exclude Test ? |
|
@plozmun its already available 👍🏻 |
True, I thought It was not 🙈 |
fabpot
approved these changes
Dec 10, 2020
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.