[Notifier] [Discord] Make webhookId argument required #39413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OskarStark yes you're right, both are required: token and the chanel id, to use the webhook. |
mpiot
approved these changes
Dec 9, 2020
| @@ -31,6 +31,15 @@ public function testCreateWithDsn() | |||
| $this->assertSame(sprintf('discord://%s?webhook_id=%s', $host, $webhookId), (string) $transport); | |||
| } | |||
|
|
|||
| public function testCreateWithNoWebhookIdThrowsMalformed(): void | |||
986c014 to
21c4768
Compare
|
Thank you @OskarStark. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the code perspective it looks like
$webhookIdcannot benullso I removed that and added a test.cc @mpiot