Skip to content

[Form] Fix UUID exception #39417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

[Form] Fix UUID exception #39417

merged 1 commit into from
Dec 9, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Dec 9, 2020

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39407
License MIT
Doc PR -

When submitting an invalid UUID, the exception thrown by Form\ChoiceList\ORMQueryBuilderLoader should be a TransformationFailedException in order to be properly intercepted by the Form\Form class

@jderusse jderusse requested a review from dunglas as a code owner December 9, 2020 15:33
@jderusse jderusse changed the base branch from 5.x to 5.2 December 9, 2020 15:33
@jderusse jderusse removed the request for review from dunglas December 9, 2020 15:33
@jderusse jderusse added this to the 5.2 milestone Dec 9, 2020
nicolas-grekas
nicolas-grekas reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't miss adding a test :)

@jderusse jderusse merged commit 730b2a5 into symfony:5.2 Dec 9, 2020
@jderusse jderusse deleted the fix-uuid-exception branch December 9, 2020 22:10
@fabpot fabpot mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

@bykclk bykclk bykclk approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Form] [Uid] Error on invalid uid submitted
5 participants
@jderusse @nicolas-grekas @yceruto @bykclk @carsonbot