[PhpUnitBridge] bump "php" to 7.1+ and "phpunit" to 7.5+ #39419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5a85d4 to
d08f524
Compare
d08f524 to
fe24f73
Compare
|
I'd really love to do that, but the bridge is also used by projects outside of the Symfony org. Those projects would be locked in on 5.2 then. |
|
Yes, but we never promised anything past our LTS versions. Having the bridge out of sync is a pain. We need to make our lives simpler from time to time, this is now :) |
ogizanagi
approved these changes
Dec 11, 2020
jderusse
approved these changes
Dec 11, 2020
fabpot
approved these changes
Dec 13, 2020
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 14, 2020
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [PhpUnitBridge] Restore SetUpTearDownTraitForV5 | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The class `SetUpTearDownTraitForV5` removed in #39419 is still needed when using PHPUNIT 7.5 (PHP 7.1) that does not have return type: https://github.com/sebastianbergmann/phpunit/blob/520723129e2b3fc1dc4c0953e43c9d40e1ecb352/src/Framework/TestCase.php#L407 Commits ------- e2198a8 [PhpUnitBridge] Restore SetUpTearDownTraitForV5
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Dec 26, 2020
This PR was merged into the 1.21-dev branch. Discussion ---------- Bump to phpunit-bridge ^5.3 See symfony/symfony#39419 Commits ------- 8e4ffb6 Bump to phpunit-bridge ^5.3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we don't maintain any branch with PHP < 7.1, we can drop support for older PHP and phpunit versions from the bridge \o/