Skip to content

[Cache] Bugfix provide the correct host and port when throwing the exception #39434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

[Cache] Bugfix provide the correct host and port when throwing the exception #39434

merged 1 commit into from
Dec 10, 2020

Conversation

renan
Copy link
Contributor

@renan renan commented Dec 10, 2020

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets none
License MIT
Doc PR none

The message before was including the result of the getMasterAddrByName call of which ended with:

Failed to retrieve master information from master name "mymaster" and address ":0".

@renan renan force-pushed the bugfix-exception-message branch 2 times, most recently from f9ae087 to dd57ee2 Compare December 10, 2020 17:28
@renan renan force-pushed the bugfix-exception-message branch from dd57ee2 to 276bbb5 Compare December 10, 2020 17:29
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Dec 10, 2020
@nicolas-grekas
Copy link
Member

Thank you @renan.

@nicolas-grekas nicolas-grekas merged commit f66b853 into symfony:5.x Dec 10, 2020
@renan renan deleted the bugfix-exception-message branch December 10, 2020 17:36
@renan
Copy link
Contributor Author

renan commented Dec 10, 2020 •
edited
Loading

Thank you, @nicolas-grekas! Hopefully the last bugfix you will hear from us about this. We are deploying this to production soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@renan @nicolas-grekas @carsonbot