[Notifier] [Discord] Fix exception message + test #39444
Conversation
| @@ -66,7 +66,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| $content = $message->getSubject(); | |||
|
|
|||
| if (\strlen($content) > 2000) { | |||
| throw new LogicException(sprintf('The subject length of "%s" transport must be less than 2000 characters.', __CLASS__)); | |||
| throw new LogicException('The subject length of a Discord message must not exceed 2000 characters.'); | |||
There was a problem hiding this comment.
I am wondering if this should be an InvalidArgumentException 🧐
There was a problem hiding this comment.
LengthException could be a good fit.
That's for 5.x anyway I suppose :)
There was a problem hiding this comment.
The fix itself is for 5.2, but we can use LengthException in 5.x, what do you think?
There was a problem hiding this comment.
PR welcome now that it's merged.
| @@ -66,7 +66,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| $content = $message->getSubject(); | |||
|
|
|||
| if (\strlen($content) > 2000) { | |||
There was a problem hiding this comment.
maybe time to move this to a private const?
also, we should consider using mb_strlen maybe? that'd require first checking if 2000 UTF-8 chars are fine
last but not least, see https://support.discord.com/hc/en-us/community/posts/360031093812:
29/10/2020 edit: it's been kinda fixed. Now, if you type over the char limit discord will send the message as a TXT file. Not ideal but it's something.
this is worth a small investigation if anyone is up to trying with an actual Discord server
|
Thank you @OskarStark. |
Before this PR the message was wrong, "less than 2000" is not correct, it can have 2000 chars, but not more.