[Notifier] [DX] Dsn::getRequiredOption() #39457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Dec 11, 2020
Comment on lines
-37
to
+35
| $consumerKey = $dsn->getOption('consumer_key'); | ||
|
|
||
| if (!$consumerKey) { | ||
| throw new IncompleteDsnException('Missing consumer_key.', $dsn->getOriginalDsn()); | ||
| } | ||
|
|
||
| $serviceName = $dsn->getOption('service_name'); | ||
|
|
||
| if (!$serviceName) { | ||
| throw new IncompleteDsnException('Missing service_name.', $dsn->getOriginalDsn()); | ||
| } | ||
|
|
||
| $consumerKey = $dsn->getRequiredOption('consumer_key'); | ||
| $serviceName = $dsn->getRequiredOption('service_name'); |
There was a problem hiding this comment.
Less noise by using the new method
c2b70b5 to
9c82bd1
Compare
jderusse
requested changes
Dec 11, 2020
jderusse
reviewed
Dec 11, 2020
|
Will fix all bridges 👍🏻 |
OskarStark
commented
Dec 12, 2020
fb1368d to
1a8a31c
Compare
OskarStark
commented
Dec 14, 2020
aee7330 to
12c7185
Compare
69d50fe to
18b84d5
Compare
OskarStark
commented
Dec 18, 2020
OskarStark
commented
Dec 18, 2020
OskarStark
commented
Dec 18, 2020
OskarStark
commented
Dec 18, 2020
e4de080 to
2b43adc
Compare
cd13710 to
ee16a5d
Compare
|
Ready to merge from my side ✌🏻 |
fabpot
approved these changes
Jan 6, 2021
|
@OskarStark Looks like the failing tests are related to the changes of this PR. Can you have a look? |
|
Sure will do later, will ping you when done |
ee16a5d to
f04d08d
Compare
|
All green now @fabpot 👍 |
f04d08d to
3f095bf
Compare
|
Thank you @OskarStark. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
notifer:5.3This will lead to a much cleaner "communication" between the factory and the transport which option is required and which is optional. This method will also reduce the code duplication in the bridges.
IMHO we should add more of those convenient "helpers" to lower the burden for new bridges.