Skip to content

Normalize exceptions messages containing methods references #39534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Normalize exceptions messages containing methods references #39534

merged 1 commit into from
Dec 17, 2020

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Dec 17, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #39399 (comment)
License MIT
Doc PR N/A

Normalizes across the codebase any exception message mentioning methods to contain a trailing ()

(Seems OK on 5.1 and 5.2 branch after this on is merged up)

@ogizanagi ogizanagi requested a review from dunglas as a code owner December 17, 2020 13:47
@carsonbot carsonbot added this to the 4.4 milestone Dec 17, 2020
@fabpot
Copy link
Member

fabpot commented Dec 17, 2020

Thank you @ogizanagi.

@fabpot fabpot merged commit 5eeb957 into symfony:4.4 Dec 17, 2020
@ogizanagi ogizanagi deleted the normlize-exc-methods branch December 17, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @fabpot @carsonbot