-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] Prepare bridges for the upcoming return type change. #39558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we should do this in all bridges actually |
Even if the others aren't affected by the BC break? |
They can be affected by any BC break we might want to do in 5.3+ |
All right. |
2655698
to
b0c2c4e
Compare
Thank you @derrabus. |
I'll simply discard the changes when merging up, right? |
I already suggested that in the past when dealing with another experimental component (Messenger or Mailer, I don't remember). IMO, dependencies to an experimental component should never be added using the |
We did so in 5.1 for notifier, and we lost the practice when preparing 5.2. |
I've bumped the conflict rules as well: #39559 |
indeed, maybe it was notifier itself in 5.1 then 😄 |
Preparation for #39549.