Skip to content

[Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface #39577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2021
Merged

[Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface #39577

merged 1 commit into from
Jan 1, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? yes
Tickets N/A
License MIT
Doc PR N/A

ArrayDenormalizer currently asks for a full-blown serializer while a simple denormalizer would be enough. I'd like to change this in Symfony 6. This PR prepares the removal of SerializerAwareInterface from this class.

@derrabus derrabus requested a review from dunglas as a code owner December 19, 2020 16:30
@derrabus derrabus force-pushed the bugfix/array-denormalizer branch 3 times, most recently from 813bee7 to b5b94c5 Compare December 19, 2020 16:43
@chalasr chalasr added this to the 5.x milestone Dec 20, 2020
@derrabus derrabus force-pushed the bugfix/array-denormalizer branch from b5b94c5 to ba5c921 Compare December 22, 2020 17:57
@fabpot
Copy link
Member

fabpot commented Jan 1, 2021

Can you rebase to retrigger tests?

@derrabus derrabus force-pushed the bugfix/array-denormalizer branch from ba5c921 to 2616bd1 Compare January 1, 2021 10:44
@derrabus
Copy link
Member Author

derrabus commented Jan 1, 2021

Sure

@derrabus derrabus force-pushed the bugfix/array-denormalizer branch from 2616bd1 to 90f6d30 Compare January 1, 2021 11:17
@fabpot
Copy link
Member

fabpot commented Jan 1, 2021

Thank you @derrabus.

@fabpot fabpot mentioned this pull request Jan 1, 2021
Closed
@fabpot fabpot merged commit b308458 into symfony:5.x Jan 1, 2021
@derrabus derrabus deleted the bugfix/array-denormalizer branch January 1, 2021 14:13
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
Deprecation Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @fabpot @dunglas @chalasr @carsonbot