Skip to content

[Notifier] [Slack] Fix incorrect check for path of Slack dsn if path is null #39590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Notifier] [Slack] Fix incorrect check for path of Slack dsn if path is null #39590

wants to merge 1 commit into from

Conversation

malteschlueter
Copy link
Contributor

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

It's possible that path of a dsn is null if the trailing slash is missing. Additional to the fix I also extended the test for this case.

@carsonbot carsonbot added this to the 5.2 milestone Dec 21, 2020
@malteschlueter malteschlueter changed the title Fix incorrect check for path of Slack dsn if path is null [Notifier] [Slack] Fix incorrect check for path of Slack dsn if path is null Dec 21, 2020
@chalasr
Copy link
Member

chalasr commented Dec 21, 2020

Duplicate of #39586

@chalasr chalasr marked this as a duplicate of #39586 Dec 21, 2020
@chalasr chalasr closed this Dec 21, 2020
@malteschlueter malteschlueter deleted the bugfix/slack-notifier-dsn-check branch December 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@malteschlueter @chalasr @carsonbot