-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] [Slack] Validate token syntax #39606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fb9e6d
to
70f5afd
Compare
The code looks correct, but I wonder if our code should have an opinion on valid Slack access tokens. To me, a token is a string that I present as I've received it if I need to authenticate. We usually don't need to parse such a token in any way. The format of those token is an implementation detail that Slack might decide to change anytime. |
I agree but in this case Slack is dealing with webhook ids and tokens which can be confusing, I think it's much easier to adopt this bridge if you know you are in the right place or not. |
72ed09e
to
59f29c5
Compare
Thank you @OskarStark. |
This PR follows #39560
@odolbeau @malteschlueter @norkunas @fabpot can you confirm all your tokens start with
xox
?From the Slack documentation:
xoxb-
xoxp-
xoxa-2