[Messenger] Setup queues once in AMQP #39608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheHett
reviewed
Dec 22, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
24afac6 to
5285ae1
Compare
TheHett
reviewed
Dec 23, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
TheHett
reviewed
Dec 23, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
0db080e to
f4054c1
Compare
jderusse
commented
Dec 23, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
f4054c1 to
c2e84c6
Compare
fabpot
approved these changes
Jan 1, 2021
|
Thank you @jderusse. |
Tobion
reviewed
Apr 27, 2021
| @@ -452,8 +447,11 @@ public function nack(\AMQPEnvelope $message, string $queueName, int $flags = \AM | |||
|
|
|||
| public function setup(): void | |||
| { | |||
| $this->setupExchangeAndQueues(); | |||
| if ($this->autoSetupExchange) { | |||
There was a problem hiding this comment.
The setup seems broken now. The setup method is public because it's called by SetupableTransportInterface. Now if you disable auto_setup and want to setup the transports manually, then it does not actually setup the exchanges and queues anymore. But that is the whole point of the setup method: being able to setup manually when autosetup is not used.
fabpot
added a commit
that referenced
this pull request
Apr 29, 2021
…(Tobion) This PR was merged into the 5.3-dev branch. Discussion ---------- [Messenger] fix manual amqp setup when autosetup disabled | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #39608 (comment) | License | MIT | Doc PR | Commits ------- 29e5bde [Messenger] fix manual amqp setup when autosetup disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease the setup, this PR also merge setup of exchange AND delayExchange.
/cc @Nyholm