[ProxyManagerBridge] fix PHP notice, switch to "friendsofphp/proxy-manager-lts" #39610
+22
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Dec 22, 2020
0d44477 to
63c3d62
Compare
chalasr
approved these changes
Dec 22, 2020
derrabus
approved these changes
Dec 22, 2020
63c3d62 to
389f530
Compare
dunglas
approved these changes
Dec 22, 2020
OskarStark
reviewed
Dec 23, 2020
src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php
Show resolved
Hide resolved
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 28, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Tweak doc around proxy manager bridge ProxyManager is already a dep of the ProxyManagerBridge, that's why only the bridge needs to be installed. Relates to symfony/symfony#39610 Commits ------- 84ac5b2 Tweak doc around proxy manager bridge
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted the fix for #39089 on the origin library at Ocramius/ProxyManager#646.
Because of the versioning policy in use at the origin library, this fix won't be available for PHP < 7.4.
We usually resort to monkey-patching to workaround the policy and still ship the fix for 4.4 (which supports PHP >= 7.1).
This time, and as explained in Ocramius/ProxyManager#630, I propose to delegate the fix to friendsofphp/proxy-manager-lts. It already embeds the fix and a few others that allow us to remove most of the monkey-patching we had to accumulate over time.