Skip to content

[Notifier] Add AllMySms Bridge #39617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

[Notifier] Add AllMySms Bridge #39617

merged 1 commit into from
Jan 14, 2021

Conversation

qdequippe
Copy link
Contributor

@qdequippe qdequippe commented Dec 23, 2020 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#14739
Recipe symfony/recipes#865

Add AllMySms bridge to Symfony Notifier

@qdequippe
Copy link
Contributor Author

@OskarStark bridge added ;)

OskarStark
OskarStark approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow perfect 🤩 just 2 minor comments

@OskarStark
Copy link
Contributor

Could you please add it to the documentation + add a recipe? 😎

@qdequippe
Copy link
Contributor Author

Could you please add it to the documentation + add a recipe?

Yes of course! Where to add the documentation? in https://github.com/symfony/symfony-docs?

@OskarStark
Copy link
Contributor

Yes you can search for other bridges, there is an open PR for GatewayAPI bridge, your should be the same, same for recipe in Symfony/recipes

@nicolas-grekas nicolas-grekas changed the title Add AllMySms Bridge [Notifier] Add AllMySms Bridge Dec 23, 2020
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Dec 23, 2020
OskarStark
OskarStark reviewed Dec 27, 2020
View reviewed changes
OskarStark
OskarStark approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go afterwards 👍

OskarStark
OskarStark approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@OskarStark
Copy link
Contributor

Thank you Quentin.

@OskarStark OskarStark merged commit 0764380 into symfony:5.x Jan 14, 2021
@qdequippe qdequippe deleted the allmysms-notifier-bridge branch January 14, 2021 13:32
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@ismail1432 ismail1432 ismail1432 left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@qdequippe @OskarStark @derrabus @ismail1432 @nicolas-grekas @chalasr @carsonbot