Skip to content

[Messenger] fix postgres transport when the retry table is the same #39674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2021
Merged

[Messenger] fix postgres transport when the retry table is the same #39674

merged 1 commit into from
Jan 1, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Dec 31, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I noticed messenger do not consume all messages when there is a retry
and when I'm using only one table for everything.

To reproduce, use the following configuration + use PG + throw an
exception in the handler

framework:
    messenger:
        failure_transport: failed

        transports:
            async: '%env(MESSENGER_TRANSPORT_DSN)%'
            failed: 'doctrine://default?queue_name=failed'

        routing:
            'App\Message\Foobar': async

The real issue is PG does not notify messenger when we UPDATE the message.

ping @dunglas

@lyrixx lyrixx requested a review from sroze as a code owner December 31, 2020 16:57
@carsonbot carsonbot added this to the 5.1 milestone Dec 31, 2020
@fabpot
Copy link
Member

fabpot commented Jan 1, 2021

Thank you @lyrixx.

@fabpot fabpot merged commit e6ba3a5 into symfony:5.1 Jan 1, 2021
@lyrixx lyrixx deleted the messenger-postgres branch January 1, 2021 13:15
This was referenced Jan 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@jderusse jderusse jderusse approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @fabpot @dunglas @jderusse @carsonbot