Skip to content

[DomCrawler] deprecate parents() in favor of ancestors() #39684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

[DomCrawler] deprecate parents() in favor of ancestors() #39684

merged 1 commit into from
Jan 3, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 2, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #26432
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.x milestone Jan 2, 2021
@xabbuh xabbuh mentioned this pull request Jan 2, 2021
Closed
@fabpot
Copy link
Member

fabpot commented Jan 3, 2021

Thank you @xabbuh.

@fabpot fabpot mentioned this pull request Jan 3, 2021
Closed
@fabpot fabpot merged commit d2e589c into symfony:5.x Jan 3, 2021
@xabbuh xabbuh deleted the issue-26432 branch January 3, 2021 08:58
ro0NL
ro0NL reviewed Jan 3, 2021
View reviewed changes
src/Symfony/Component/DomCrawler/Crawler.php
*
* @return static
*
* @throws \InvalidArgumentException When current node is empty
*/
public function parents()
{
@trigger_deprecation('symfony/dom-crawler', '5.3', sprintf('The %s() method is deprecated, use ancestors() instead.', __METHOD__));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the @ isnt needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e970027
good catch, thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chalasr!

@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@simonhammes simonhammes mentioned this pull request Aug 5, 2021
Merged
TavoNiievez pushed a commit to Codeception/lib-innerbrowser that referenced this pull request Aug 30, 2021
@simonhammes @TavoNiievez
Fix symfony/dom-crawler 5.3 deprecation
b33936c 
symfony/symfony#39684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@chalasr chalasr chalasr left review comments

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Deprecation DomCrawler Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[DomCrawler] Inconsistency between children and parents
8 participants
@xabbuh @fabpot @dunglas @OskarStark @ro0NL @derrabus @chalasr @carsonbot