Skip to content

[Mailer][Mime][TwigBridge][Validator] Allow egulias/email-validator 3.x #39685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"predis/predis": "~1.1",
"psr/http-client": "^1.0",
"psr/simple-cache": "^1.0",
"egulias/email-validator": "^2.1.10",
"egulias/email-validator": "^2.1.10|^3.1",
"symfony/phpunit-bridge": "^5.2",
"symfony/security-acl": "~2.8|~3.0",
"phpdocumentor/reflection-docblock": "^3.0|^4.0|^5.0",
Expand All @@ -143,6 +143,7 @@
"twig/markdown-extra": "^2.12"
},
"conflict": {
"egulias/email-validator": "~3.0.0",
"masterminds/html5": "<2.6",
"monolog/monolog": ">=2",
"phpdocumentor/reflection-docblock": "<3.0|>=3.2.0,<3.2.2",
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"twig/twig": "^1.43|^2.13|^3.0.4"
},
"require-dev": {
"egulias/email-validator": "^2.1.10",
"egulias/email-validator": "^2.1.10|^3",
"symfony/asset": "^3.4|^4.0|^5.0",
"symfony/dependency-injection": "^3.4|^4.0|^5.0",
"symfony/error-handler": "^4.4|^5.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Mailer/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
],
"require": {
"php": ">=7.1.3",
"egulias/email-validator": "^2.1.10",
"egulias/email-validator": "^2.1.10|^3",
"psr/log": "~1.0",
"symfony/event-dispatcher": "^4.3",
"symfony/mime": "^4.4|^5.0",
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/Mime/Address.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\Mime;

use Egulias\EmailValidator\EmailValidator;
use Egulias\EmailValidator\Validation\MessageIDValidation;
use Egulias\EmailValidator\Validation\RFCValidation;
use Symfony\Component\Mime\Encoder\IdnAddressEncoder;
use Symfony\Component\Mime\Exception\InvalidArgumentException;
Expand Down Expand Up @@ -51,7 +52,7 @@ public function __construct(string $address, string $name = '')
$this->address = trim($address);
$this->name = trim(str_replace(["\n", "\r"], '', $name));

if (!self::$validator->isValid($this->address, new RFCValidation())) {
if (!self::$validator->isValid($this->address, class_exists(MessageIDValidation::class) ? new MessageIDValidation() : new RFCValidation())) {
throw new RfcComplianceException(sprintf('Email "%s" does not comply with addr-spec of RFC 2822.', $address));
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/Mime/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@
"symfony/polyfill-mbstring": "^1.0"
},
"require-dev": {
"egulias/email-validator": "^2.1.10",
"egulias/email-validator": "^2.1.10|^3.1",
"symfony/dependency-injection": "^3.4|^4.1|^5.0"
},
"conflict": {
"egulias/email-validator": "~3.0.0",
"symfony/mailer": "<4.4"
},
"autoload": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function validate($value, Constraint $constraint)

if (Email::VALIDATION_MODE_STRICT === $constraint->mode) {
if (!class_exists(EguliasEmailValidator::class)) {
throw new LogicException('Strict email validation requires egulias/email-validator ~1.2|~2.0.');
throw new LogicException('Strict email validation requires egulias/email-validator ^2.1.10|^3.');
}

$strictValidator = new EguliasEmailValidator();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function testLegacyValidatorConstructorStrict()
{
$this->validator = new EmailValidator(true);
$this->validator->initialize($this->context);
$this->validator->validate('example@localhost', new Email());
$this->validator->validate('example@mywebsite.tld', new Email());

$this->assertNoViolation();
}
Expand Down Expand Up @@ -211,7 +211,7 @@ public function testModeStrict()
{
$constraint = new Email(['mode' => Email::VALIDATION_MODE_STRICT]);

$this->validator->validate('example@localhost', $constraint);
$this->validator->validate('example@mywebsite.tld', $constraint);

$this->assertNoViolation();
}
Expand Down Expand Up @@ -256,7 +256,7 @@ public function testStrict()
{
$constraint = new Email(['strict' => true]);

$this->validator->validate('example@localhost', $constraint);
$this->validator->validate('example@mywebsite.tld', $constraint);

$this->assertNoViolation();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"symfony/translation": "^4.2",
"doctrine/annotations": "^1.10.4",
"doctrine/cache": "~1.0",
"egulias/email-validator": "^2.1.10"
"egulias/email-validator": "^2.1.10|^3"
},
"conflict": {
"doctrine/lexer": "<1.0.2",
Expand Down