-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle][Messenger] Added RouterContextMiddleware #39688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a55b33
to
b3beab6
Compare
src/Symfony/Bundle/FrameworkBundle/Messenger/RouterContextMiddleware.php
Outdated
Show resolved
Hide resolved
b3beab6
to
9a32c89
Compare
src/Symfony/Bundle/FrameworkBundle/Messenger/RouterContextMiddleware.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Messenger/RouterContextMiddleware.php
Outdated
Show resolved
Hide resolved
9a32c89
to
b13bb37
Compare
b13bb37
to
78b8d3f
Compare
78b8d3f
to
1377b21
Compare
on deps=low |
c5ef324
to
821fa53
Compare
nicolas-grekas
approved these changes
Feb 7, 2021
821fa53
to
8fe8b96
Compare
derrabus
approved these changes
Feb 9, 2021
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling a message in async, we, sometimes need the Router Context to generate absolute URL. ie:
People can use the configuration
router.default_uri
to workaround and fix the issue, but this does not work when the web application servers several domains.This PR provide a new middleware that store the current router context in a stamp, and restore the context when processing the message.