[String] Made AsciiSlugger fallback to parent locale's symbolsMap #39699
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| $unicodeString = $unicodeString->replace($char, ' '.$replace.' '); | ||
| if (\is_array($this->symbolsMap)) { | ||
| $map = null; | ||
| // if we have a symbols map for the requested locale, use it |
There was a problem hiding this comment.
no need for the comment nor for the initialization
There was a problem hiding this comment.
I think the initialization is needed, in case neither $locale nor $parent are present in the $symbolsMap array.
0f74f55 to
d2001cf
Compare
d2001cf to
916a8cf
Compare
|
Thank you @jontjs. |
The Slugger already performed a fallback from (e.g.) 'en_GB' to (e.g.) 'en' for the transliterator, this PR adds similar behaviour for the symbols map.