Skip to content

[Notifier] Add Octopush notifier transport #39702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

[Notifier] Add Octopush notifier transport #39702

merged 1 commit into from
Jan 14, 2021

Conversation

aurelienmartin
Copy link

@aurelienmartin aurelienmartin commented Jan 4, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#14779
Recipe PR symfony/recipes#870

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@aurelienmartin aurelienmartin changed the title Add Octopush notifier transport [Notifier] Add Octopush notifier transport Jan 4, 2021
jderusse
jderusse reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR,

I've few comments, but it would be great to get access to the documentation of the API without creating a account.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Jan 4, 2021
OskarStark
OskarStark reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after my comments 👍

@symfony symfony deleted a comment from derrabus Jan 7, 2021
@OskarStark
Copy link
Contributor

OskarStark commented Jan 7, 2021 •
edited
Loading

@aurelienmartin can you please add a recipe like done for #39568 ? Thanks!

@aurelienmartin aurelienmartin mentioned this pull request Jan 8, 2021
Merged
@OskarStark
Copy link
Contributor

Thank you Aurélien.

@OskarStark OskarStark merged commit f2ba203 into symfony:5.x Jan 14, 2021
@OskarStark OskarStark modified the milestones: 5.x, 5.3 Jan 14, 2021
@OskarStark OskarStark mentioned this pull request Jan 14, 2021
Merged
@nicolas-grekas nicolas-grekas modified the milestones: 5.3, 5.x Jan 14, 2021
OskarStark added a commit that referenced this pull request Jan 15, 2021
@OskarStark
minor #39832 [Notifier] [Octopush] Use the correct provider (OskarStark)
f1df709 
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [Octopush] Use the correct provider

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Follows #39702

Commits
-------

9ecef3b [Notifier] [Octopush] Use the correct provider
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
8 participants
@aurelienmartin @carsonbot @OskarStark @fabpot @jderusse @nicolas-grekas @derrabus @aurelienheyliot