[DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass #39747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
284206b to
f16230b
Compare
OskarStark
approved these changes
Jan 7, 2021
nicolas-grekas
approved these changes
Jan 7, 2021
|
Thank you @derrabus. |
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckTypeDeclarationsPasscurrently explodes if it encounters one of following the new builtin types of PHP 8:false(can only appear as part of a union)mixed(we don't need to check anything)In either case, the pass will try to call a function
is_false()/is_mixed()and fail.This PR should fix both cases.