[DependencyInjection] Add a remove() method to the PHP configurator #39806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/DependencyInjection/Loader/Configurator/AbstractServiceConfigurator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/Configurator/ServicesConfigurator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/Configurator/ServicesConfigurator.php
Outdated
Show resolved
Hide resolved
dunglas
commented
Jan 13, 2021
| @@ -58,6 +59,11 @@ public function __construct(ContainerBuilder $container, array $instanceof, bool | |||
|
|
|||
| public function __destruct() | |||
| { | |||
| if ($this->destructed) { | |||
There was a problem hiding this comment.
This trick prevents the destructor to re-add a service when it has been removed just after being added (see tests).
c9e8318 to
0540c6f
Compare
0540c6f to
dcf75fa
Compare
nicolas-grekas
approved these changes
Jan 19, 2021
|
Thank you @dunglas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This especially useful in the
configureContainer()method of the kernel. It allows to not use a compiler pass to remove some services (for instance, in test mode).