Skip to content

Make EmailMessage & SmsMessage transport nullable #39812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Make EmailMessage & SmsMessage transport nullable #39812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Symfony/Component/Notifier/Message/EmailMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,14 @@ public function getOptions(): ?MessageOptionsInterface
/**
* @return $this
*/
public function transport(string $transport): self
public function transport(?string $transport): self
{
if (!$this->message instanceof Email) {
throw new LogicException('Cannot set a Transport on a RawMessage instance.');
}
if (null === $transport) {
return $this;
}

$this->message->getHeaders()->addTextHeader('X-Transport', $transport);

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Message/SmsMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function getSubject(): string
/**
* @return $this
*/
public function transport(string $transport): self
public function transport(?string $transport): self
{
$this->transport = $transport;

Expand Down