Skip to content

[TwigBridge] LintCommand supports Github Actions annotations #39826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2021
Merged

[TwigBridge] LintCommand supports Github Actions annotations #39826

merged 1 commit into from
Jul 25, 2021

Conversation

YaFou
Copy link
Contributor

@YaFou YaFou commented Jan 14, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #39122 (for lint:twig)
License MIT
Doc PR TODO

Adds a format to the Twig linter command to print Github Actions annotations when an error occurred (documentation). There is a new format: github and the command will detect automatically the format to use in comparison with the environment.

See a workflow example: https://github.com/YaFou/symfony-39826/actions/runs/485093369

TODO:

  • Changelog
  • Test with a real project

@carsonbot
Copy link

Hey!

I like what you have done here. Keep up the good work.

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@YaFou YaFou marked this pull request as ready for review January 14, 2021 09:30
@YaFou YaFou force-pushed the github-twig-lint-command branch from dc33317 to c46d100 Compare January 14, 2021 09:33
@YaFou YaFou force-pushed the github-twig-lint-command branch from c46d100 to e705232 Compare January 14, 2021 09:49
@YaFou YaFou requested a review from stof January 14, 2021 10:23
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Jan 14, 2021
@YaFou YaFou mentioned this pull request Jan 14, 2021
Closed
2 tasks
@YaFou YaFou force-pushed the github-twig-lint-command branch from e705232 to b51062a Compare January 14, 2021 20:57
@chalasr
Copy link
Member

chalasr commented Mar 24, 2021

@YaFou Could you address the remaining comments and rebase your branch against the latest 5.x? Or do you want someone else to take over?

@YaFou
Copy link
Contributor Author

YaFou commented Mar 24, 2021

@YaFou Could you address the remaining comments and rebase your branch against the latest 5.x? Or do you want someone else to take over?

I will do it this evening.

@YaFou YaFou force-pushed the github-twig-lint-command branch 6 times, most recently from 78f4dff to 82e7148 Compare May 24, 2021 15:55
@YaFou
Copy link
Contributor Author

YaFou commented May 24, 2021

The tests failed because GithubActionReporter was not found. However, I don't understand because I bumped the symfony/console version in composer.json to 5.3 (where GithubActionReporter was implemented).

@YaFou YaFou force-pushed the github-twig-lint-command branch from 82e7148 to e5d4ec3 Compare May 25, 2021 18:42
@YaFou YaFou requested a review from OskarStark May 25, 2021 19:31
@YaFou YaFou requested a review from ogizanagi May 25, 2021 19:31
@YaFou YaFou force-pushed the github-twig-lint-command branch from e5d4ec3 to a0a40c1 Compare May 26, 2021 09:30
@YaFou YaFou requested a review from ogizanagi May 26, 2021 09:30
@YaFou YaFou force-pushed the github-twig-lint-command branch from a0a40c1 to 1e5a3dc Compare May 26, 2021 09:32
@YaFou YaFou force-pushed the github-twig-lint-command branch from 1e5a3dc to 202eb26 Compare June 27, 2021 09:06
@fabpot
Copy link
Member

fabpot commented Jul 25, 2021

Thank you @YaFou.

@fabpot fabpot mentioned this pull request Jul 25, 2021
Closed
@fabpot fabpot merged commit b8d7e1f into symfony:5.4 Jul 25, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@stof stof Awaiting requested review from stof

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Feature Status: Reviewed TwigBridge
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

Add Github annotations support to all linters
8 participants
@YaFou @carsonbot @chalasr @fabpot @stof @OskarStark @ogizanagi @nicolas-grekas