Skip to content

[Uid] Add fromBase58(), fromBase32(), fromRfc4122() and fromBinary() methods #39850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

[Uid] Add fromBase58(), fromBase32(), fromRfc4122() and fromBinary() methods #39850

merged 1 commit into from
Jan 20, 2021

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Jan 15, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets #39801
License MIT
Doc PR -

nicolas-grekas
nicolas-grekas reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this.

@jderusse jderusse added this to the 5.x milestone Jan 18, 2021
nicolas-grekas
nicolas-grekas approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I updated the implementation to rely on a generic logic)

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 20, 2021
Closed
@nicolas-grekas nicolas-grekas merged commit c5140c2 into symfony:5.x Jan 20, 2021
@fancyweb fancyweb deleted the uid-from-format branch January 21, 2021 08:05
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Uid
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @jderusse @carsonbot