Skip to content

[Mime] Escape commas in address names #39866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

[Mime] Escape commas in address names #39866

merged 1 commit into from
Mar 12, 2021

Conversation

YaFou
Copy link
Contributor

@YaFou YaFou commented Jan 17, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39416
License MIT
Doc PR --

Before:

$address = new Address('fabien@symfony.com', 'Fabien, Potencier');
$address->toString(); // Fabien, Potencier <fabien@symfony.com> -> Interpreted like two emails

After:

$address = new Address('fabien@symfony.com', 'Fabien, Potencier');
$address->toString(); // "Fabien, Potencier" <fabien@symfony.com>

@carsonbot carsonbot added this to the 4.4 milestone Jan 17, 2021
@carsonbot
Copy link

Hey!

I didn't know that was capable of this emotion. I really really like reviewing this PR. Well done.

I think @Cartman34 has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@OskarStark OskarStark requested a review from fabpot January 18, 2021 13:30
@YaFou YaFou force-pushed the comma-in-address-name branch from 079196f to c89ff21 Compare January 18, 2021 19:27
@YaFou YaFou force-pushed the comma-in-address-name branch from c89ff21 to 39e9158 Compare January 19, 2021 18:34
@fabpot
Copy link
Member

fabpot commented Mar 12, 2021

Thank you @YaFou.

@fabpot fabpot merged commit 93467c5 into symfony:4.4 Mar 12, 2021
This was referenced Mar 29, 2021
Merged
Merged
@lolli42 lolli42 mentioned this pull request Mar 31, 2021
Closed
@althaus althaus mentioned this pull request May 18, 2021
Closed
@YaFou YaFou deleted the comma-in-address-name branch May 23, 2021 08:35
@vinibrsl vinibrsl mentioned this pull request Oct 27, 2022
Closed
@vinibrsl vinibrsl mentioned this pull request Nov 28, 2022
Merged
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull request Nov 28, 2022
@vinibrsl
Encode names to support special characters (#1)
8e6d3a4 
This PR encodes names with quotes when building e-mails, e.g. "John Doe"
<johndoe@provider.test>. This adds support for special names with commas
and even quotes.

Related: symfony/symfony#39866,
plausible/analytics#1885
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull request Nov 28, 2022
@vinibrsl
Encode names to support special characters (#1)
9ff9249 
This PR encodes names with quotes when building e-mails, e.g. "John Doe"
<johndoe@provider.test>. This adds support for special names with commas
and even quotes.

Related: symfony/symfony#39866,
plausible/analytics#1885
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull request Nov 28, 2022
@vinibrsl
Encode names to support special characters (#1)
d544aa1 
This PR encodes names with quotes when building e-mails, e.g. "John Doe"
<johndoe@provider.test>. This adds support for special names with commas
and even quotes.

Related: symfony/symfony#39866,
plausible/analytics#1885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cartman34 Cartman34 Cartman34 left review comments

@sstok sstok sstok left review comments

@fbourigault fbourigault fbourigault left review comments

@fabpot fabpot fabpot approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Bug Mime Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@YaFou @carsonbot @fabpot @Cartman34 @sstok @fbourigault @maxhelias