[HttpKernel] Show full URI when route not found #39893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This is.. this is amazing. Thank you! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
@nicolas-grekas Added some tests. |
OskarStark
reviewed
Jan 20, 2021
src/Symfony/Component/HttpKernel/Tests/EventListener/RouterListenerTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 29, 2021
src/Symfony/Component/HttpKernel/Tests/EventListener/RouterListenerTest.php
Outdated
Show resolved
Hide resolved
When accessing a route that does not exist, Symfony throws a `NotFoundHttpException` that says `No route found for "POST /path"`. On some projects this might be good enough to find the root cause, but on projects that have lots of routes on different hosts, it becomes hard to understand how the request was initiated. Was it done over HTTP or HTTPS? What was the hostname? Did the user specify a port? To make this easier, we now show the full URI of the path, like this: `No route found for "POST https://www.symfony.com/path"`.
OskarStark
reviewed
Jan 29, 2021
src/Symfony/Component/HttpKernel/Tests/EventListener/RouterListenerTest.php
Show resolved
Hide resolved
fabpot
approved these changes
Feb 5, 2021
|
Thank you @ruudk. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing a route that does not exist, Symfony throws a
NotFoundHttpExceptionthat saysNo route found for "POST /path".On some projects this might be good enough to find the root cause, but on projects that have lots of routes on different hosts, it becomes hard to understand how the request was initiated. Was it done over HTTP or HTTPS? What was the hostname? Did the user specify a port?
To make this easier, we now show the full URI of the path, like this:
No route found for "POST https://www.symfony.com/path".