Skip to content

[PropertyInfo] Fix breaking change with has*(arguments...) methods #39896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

[PropertyInfo] Fix breaking change with has*(arguments...) methods #39896

merged 1 commit into from
Jan 22, 2021

Conversation

YaFou
Copy link
Contributor

@YaFou YaFou commented Jan 19, 2021

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39885
License MIT
Doc PR symfony/symfony-docs#...

Until 5.0:

class Dummy
{
    private $elements;

    public function hasElement($element): bool
    {
        // ...
    }
}

$extractor = new ReflectionExtractor();
$extractor->isReadable('Dummy', 'element'); // false

After 5.0:

class Dummy
{
    private $elements;

    public function hasElement($element): bool
    {
        // ...
    }
}

$extractor = new ReflectionExtractor();
$extractor->isReadable('Dummy', 'element'); // true => BREAKING CHANGE

@YaFou YaFou requested a review from dunglas as a code owner January 19, 2021 19:14
@carsonbot carsonbot added this to the 5.1 milestone Jan 19, 2021
@YaFou YaFou mentioned this pull request Jan 19, 2021
Closed
@YaFou YaFou force-pushed the has-method-property-info branch from 9d3ea9a to 25d1299 Compare January 19, 2021 19:23
@YaFou YaFou force-pushed the has-method-property-info branch from 25d1299 to 37cc16e Compare January 20, 2021 21:16
@pamil
Copy link
Contributor

pamil commented Jan 21, 2021

It solves the issue for me (#39885), thanks! Travis CI build for PHP 8.0 is failing due to some networking issues, could it be restarted? Same for AppVeyor, it seems like an unrelated failure.

@xabbuh
Copy link
Member

xabbuh commented Jan 21, 2021

@pamil CI restarted and green

@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2021

Thank you @YaFou.

@xabbuh xabbuh merged commit de8ddfd into symfony:5.1 Jan 22, 2021
@YaFou YaFou deleted the has-method-property-info branch January 22, 2021 17:45
This was referenced Jan 27, 2021
Merged
Merged
@Tomanhez Tomanhez mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@dunglas dunglas dunglas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@YaFou @pamil @xabbuh @dunglas @OskarStark @carsonbot