Skip to content

[Console] add option --short to the list command #39904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

[Console] add option --short to the list command #39904

merged 1 commit into from
Jan 20, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR is a follow up of #39851, triggered by @wouterj's comment at #39851 (review).

This new option should enable creating fast shell auto-completion, by allowing the list command to run fast.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Jan 20, 2021
chalasr
chalasr approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@wouterj
Copy link
Member

wouterj commented Jan 20, 2021 •
edited
Loading

Thanks :)

Note that I started experimenting with autocompletion a while ago. I just pushed my progress thus far today: wouterj@2bdf798 (it's really hacky, it should probably use a custom descriptor instead, relying on this new feature). I don't have much priority to finish this feature, so if anyone wants to continue: feel free to do so

This is a little demo for a skeleton app without this fast option:

autocompletion demo

@nicolas-grekas nicolas-grekas force-pushed the console-list-short branch 2 times, most recently from 18b05ef to 0262b11 Compare January 20, 2021 13:26
@chalasr
Copy link
Member

chalasr commented Jan 20, 2021 •
edited
Loading

Thank you @nicolas-grekas.

edit: Merge aborted just in time :)

@chalasr
Copy link
Member

chalasr commented Jan 20, 2021

Thank you (again) @nicolas-grekas.

@chalasr chalasr merged commit dc9db1e into symfony:5.x Jan 20, 2021
@chalasr chalasr mentioned this pull request Jan 20, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the console-list-short branch January 20, 2021 19:45
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

@chalasr chalasr chalasr approved these changes

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Console Feature Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @wouterj @chalasr @jderusse @carsonbot